Skip to content

Add support for non-SCM program root, mbed new and fixes #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2016

Conversation

screamerbg
Copy link
Contributor

@screamerbg screamerbg commented Jun 6, 2016

This PR adds

New:

Fixes:

Improvements:

  • Unify how tools dir, target and macros are handled for commands compile, export and test
  • Pass all SCM commands to Repo class than directly to the relevant SCM classes (proxy)

Added switches:
 * --program and --library to enforce behavior of "new"
 * --mbedlib to enable new programs based on the mbed library (mbed Classic)
 * --create-only to only create the program/library and not import mbed-os or mbed library (autmation)
 * changed "scm" from positional argument to --scm switch
Also added support for "none" as option to --scm which prevents git and hg repositories to be created (plain folder programs support)
@screamerbg screamerbg changed the title Add support for non-SCM program root Add support for non-SCM program root, mbed new and fixes Jun 6, 2016
@@ -19,7 +19,7 @@
# Default paths to Mercurial and Git
hg_cmd = 'hg'
git_cmd = 'git'
ver = '0.4.0'
ver = '0.4.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say this is more a 0.5.0 (new minor), not a 0.4.1 (new patch), since the differences in behaviour are quite significat?

dict(name='--scm', nargs='?', help='Source control management. Currently supported: %s. Default: git' % ', '.join([s.name for s in scms.values()])),
dict(name='--program', action='store_true', help='Force creation of an mbed program. Default: auto.'),
dict(name='--library', action='store_true', help='Force creation of an mbed library. Default: auto.'),
dict(name='--mbedlib', action='store_true', help='Add the mbed library instead of mbed-os into the program.'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ?

@bogdanm
Copy link
Contributor

bogdanm commented Jun 6, 2016

Looks good! +1.

Disallow execution of mbed commands without program root
Fixed Repo.remove() routine
Fixed corner case where `mbed update` won't remove obsolete libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants