Skip to content

mbed CLI 0.7.x fixes and additions #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 22, 2016
Merged

Conversation

screamerbg
Copy link
Contributor

@screamerbg screamerbg commented Jun 17, 2016

Fixes:

Documentation:

@bogdanm @sg-

@screamerbg screamerbg changed the title mbed CLI 0.7.x fixes mbed CLI 0.7.x fixes and additions Jun 18, 2016
@jupe
Copy link

jupe commented Jun 20, 2016

please create properly release this time

@@ -35,7 +35,7 @@


# Application version
ver = '0.7.3'
ver = '0.7.11'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole file should refactor more modular parts so that its easier to follow and further develop, now there is 2000 lines of big code chunk..

@jupe
Copy link

jupe commented Jun 20, 2016

by the way, when you start create test cases against all these changes? how you can ensure now that existing features are not going to be broken after you merge something without proper tests?

@screamerbg
Copy link
Contributor Author

@jupe There is 0.7.3 release already. Regarding testing - mbed CLI could definitely benefit more tests. Hope you're happy to contribute to tests. Looking forward to it.

@SeppoTakalo
Copy link

This is not fixing the #215, it is just making the problem disappear. But files still exist.

@sg-
Copy link
Contributor

sg- commented Jun 21, 2016

LGTM 👍

@screamerbg screamerbg merged commit 79d4eb0 into ARMmbed:master Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants