Skip to content

mbed CLI 0.8 (EPR) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 29, 2016
Merged

mbed CLI 0.8 (EPR) #230

merged 8 commits into from
Jun 29, 2016

Conversation

screamerbg
Copy link
Contributor

@screamerbg screamerbg commented Jun 27, 2016

New:

Fixes:

@bridadan
Copy link
Contributor

I understand this change:

.lib do not allow named branches (only rev hashes)

But this may be a breaking change for a few of the Oulu test apps. The Oulu team needs to be made aware of this change before this gets merged to prevent merge blockages on ARMmbed/mbed-os.

cc @jupe

Ditto for deprecating mbed compile -tests

https://github.com/ARMmbed/mbed-os/blob/master/circle.yml#L4

These should be updated first before merging.

@screamerbg screamerbg changed the title Development mbed CLI 0.8 (EPR) Jun 27, 2016
@screamerbg
Copy link
Contributor Author

@bridadan Thanks for pointing these out. Happy to change circle.yml?

@bridadan
Copy link
Contributor

bridadan commented Jun 27, 2016

Done: ARMmbed/mbed-os#413

I'm not sure if removing mbed compile --tests now is the right time. I think instead printing out a message when mbed compile --tests is invoked suggesting the alternative mbed test --compile might be a better path forward, at least for the next few releases. This will directly affect people's workflow and I think having a few releases with warnings makes sense before completely removing it.

@screamerbg
Copy link
Contributor Author

@bridadan Not sure that we'd want partner engineers to use the compile --test when they could use much better workflow that is already provided by mbed test. In that sense deprecating these now makes more sense.

@bridadan
Copy link
Contributor

You're right, we should be encouraging them to use mbed test instead of mbed compile --tests. But they won't know an alternative if we don't point them at it. That's why I'm saying we should print a warning saying they should use mbed test instead of removing it.

@sg-
Copy link
Contributor

sg- commented Jun 29, 2016

All partners have been shown how to use mbed test. If we have CI or internal devs using mbed compile --tests they should be using the supported workflow.

@sg- sg- merged commit 2f6b150 into ARMmbed:master Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants