Skip to content

Add -l/--latest-deps option to update #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2017
Merged

Add -l/--latest-deps option to update #512

merged 2 commits into from
Jun 21, 2017

Conversation

theotherjimmy
Copy link
Contributor

Resolves #511

@screamerbg
Copy link
Contributor

screamerbg commented Jun 15, 2017 •
edited
Loading

@theotherjimmy Like the size the patch (really awesome!!), but not sure about the switch name.
-r/--recursive leaves the impression that update doesn't work recursively if not specified. But update with no parameter would only update the current repository item and align sub-repositories to match the correct hash by recursively update them as well.

@bridadan
Copy link
Contributor

@screamerbg Fair point. What if it was named --recursively-update? It's getting a bit lengthy now, but that may do a better job of describing the intended action.

@theotherjimmy
Copy link
Contributor Author

@screamerbg Do you have an alternative suggestion? I think -f/--force was suggested in #511, but that does not really explain itself well.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Jun 20, 2017 •
edited
Loading

-u/--update-deps?
-i/--include-deps?
-i/--ignore-lib-files?
-m/--most-recent-deps?
-l/--latest-deps?

@theotherjimmy theotherjimmy mentioned this pull request Jun 20, 2017
Closed
@theotherjimmy
Copy link
Contributor Author

I kinda like -l/--latest-deps so I rewrote history to pretend that's what I was suggesting all along. 😄 What do you think of this version @screamerbg

@theotherjimmy theotherjimmy changed the title Add -r/--recursive option to update Add -l/--latest-deps option to update Jun 20, 2017
bridadan
bridadan approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I dig it 👍

@screamerbg
Copy link
Contributor

And we have a winner gentleman :) LGTM

@screamerbg screamerbg merged commit 6bf747a into ARMmbed:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theotherjimmy @screamerbg @bridadan