Skip to content

Add link to mbed CLI for Windows Installer (supercedes PR 540) #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Add link to mbed CLI for Windows Installer (supercedes PR 540) #542

merged 2 commits into from
Sep 14, 2017

Conversation

dhwalters423
Copy link
Contributor

Added a reference to the mbed CLI for Windows Installer in the Installation section.

This information was not immediately obvious and I think it would be valuable to have this information more prominent in this doc.

This pull request supercedes PR 540: I did a merge rather than a rebase in 540. This PR includes the original commit plus it has been rebased from latest version of master: b6b070c
@screamerbg @AnotherButler

Added a reference to the mbed CLI for Windows Installer in the Installation section.
@theotherjimmy theotherjimmy changed the title Added link to mbed CLI for Windows Installer (supercedes PR 540) Add link to mbed CLI for Windows Installer (supercedes PR 540) Sep 13, 2017
README.md Outdated
@@ -80,6 +80,8 @@ $ sudo apt-get install libc6:i386 libncurses5:i386 libstdc++6:i386

### Installing Mbed CLI

Windows users can use the [mbed CLI for Windows installer](https://docs.mbed.com/docs/mbed-os-handbook/en/latest/dev_tools/cli_install/) which will install mbed CLI and all necessary requirements with one installer.
Copy link
Contributor

@theotherjimmy theotherjimmy Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change which will => to? I think it conveys the message better and is shorter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change "mbed CLI" to "Mbed CLI" for proper branding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnotherButler @theotherjimmy Done with commit edac8c9 :)

@theotherjimmy
Copy link
Contributor

@AnotherButler Could you take a look please?

Changed mbed => Mbed and which will => to
@theotherjimmy theotherjimmy merged commit ac5293d into ARMmbed:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants