Skip to content

Fix Git URL regex so it doesn't match Windows paths #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

screamerbg
Copy link
Contributor

This patch fixes the regular expression that matches Git URLs so it doesn't match Windows paths. Without this patch, the path of local (unpublished) repositories on Windows, e.g. "c:/users/path/repo.git" which only exists locally, will be identified as remote repositories. This also fixes py.test on Windows #600

D:\Work\neo>py.test
============================= test session starts =============================
platform win32 -- Python 2.7.11, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
rootdir: D:\Work\neo, inifile:
collected 40 items

test\add_test.py ........
test\import_test.py ....
test\ls_test.py ....
test\remove_test.py ........
test\sync_update_test.py ................

========================= 40 passed in 550.85 seconds =========================

…it URL

E.g. c:/temp/pytest-of-Screamer/pytest-8/test_import_after_add_git1_0/test3.git
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small diff. It looks like it does not break linux (Circle CI passed)

@theotherjimmy
Copy link
Contributor

@screamerbg I'll merge this now. Could you push a new patch release of mbed-cli when you get the chance?

@theotherjimmy theotherjimmy merged commit 676dc1c into ARMmbed:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants