Skip to content

python 2->3 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

python 2->3 #609

wants to merge 4 commits into from

Conversation

davidhyman
Copy link
Contributor

@davidhyman davidhyman commented Jan 11, 2018

according to futurize
+ some minor fixes

Really we'll need something like workflows on circleci 2 to check the full test suite against Python3. Could do that as a separate ticket, or the same.

@davidhyman
Copy link
Contributor Author

ref #601

@theotherjimmy
Copy link
Contributor

@davidhyman I would like to have the workflows as part of this PR please. We may need to block this on support for mbed compile, mbed test and mbed export

@screamerbg
Copy link
Contributor

Looks great! Thanks @davidhyman. This would have to wait until the other mbed OS tools need to support Python3 first as @theotherjimmy explained.

@cmonr
Copy link
Contributor

cmonr commented Apr 11, 2018

@theotherjimmy @screamerbg Once this (ARMmbed/mbed-os#6592) goes in, would anyone be opposed to moving this PR along?

@screamerbg
Copy link
Contributor

@davidhyman Could you please rebase this PR?

@cmonr
Copy link
Contributor

cmonr commented Apr 24, 2018

@davidhyman I wanted to check something with this PR.

The goal should be to add compatibility to make sure that mbed-cli can run with either Py2 or Py3. Does this PR do that? If so, would you mind changing the PR title to reflect this? (python 2->3 to python 2 & 3)

@screamerbg
Copy link
Contributor

@davidhyman Could you please rebase this PR on top of master?

@cmonr
Copy link
Contributor

cmonr commented May 9, 2018

Closing due to inactivity. Changes will be integrated into a separate PR for review.

@cmonr cmonr closed this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants