Show progress only on tty terminals #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screamerbg
force-pushed
the
f/progress-on-tty
branch
from
2ec6e7b to
41fc24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends PR #593 which adds progress bar to mbed CLI, so progress is shown only on TTY terminals.
Without this patch, the progress is reported regardless whether mbed CLI is executed on TTY terminal and therefore progress appears even if the output of mbed CLI is redirected to a file. For example
D:\Work\1>mbed new testprogram2 > log.txtproduced the following log.txt file:With this patch: