Add an optional flag --no-requirements to update command #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamCHogg Could you also include this
|
|
@theotherjimmy Done |
theotherjimmy
suggested changes
Aug 7, 2018
mbed/mbed.py
Outdated
| hidden_aliases=['ad'], | ||
| help='Add library from URL', | ||
| description=( | ||
| "Adds mbed library and its dependencies from a source control based URL\n" | ||
| "(GitHub, Bitbucket, mbed.org) into an existing program.\n" | ||
| "Use \"mbed import <URL>\" to import as a program")) | ||
| def add(url, path=None, ignore=False, depth=None, protocol=None, insecure=False, offline=False, top=True): | ||
| def add(url, path=None, ignore=False, depth=None, protocol=None, insecure=False, offline=False, no_requirements=False, top=True): | ||
|
|
There was a problem hiding this comment.
Could you remove this whitespace change?
|
@screamerbg Any hesitation with merging this? (I'm aware that you're away all week. We can wait to merge this if you don't have time to review it) |
theotherjimmy
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional flag
--no-requirementsto theupdatecommand. The default behaviour stays the same, but when the flag is enabled it will no longer check for and install missing python requirements.