Return None from MbedTerminal Constructor #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we examine `self.serial` to determine the success of the constructor, I made all `return False` statements within the constructor set `self.serial = None`. That way the current code should catch the failures without any additional changes Fixes ARMmbed#688
Since the prior commit made it impossible to distinguish between these 2 types of failure, I lumped them all into a single `try` so that they can share logic. It's a bit shorted this way
|
@screamerbg This makes the current behavior not produce the warning. I'm not sure if you wanted to distinguish between these failure modes. If you do, we may have to change the API of the MbedTerminal class to distinguish these errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we examine
self.serialto determine the success of theconstructor, I made all
return Falsestatements within the constructorset
self.serial = None. That way the current code should catch thefailures without any additional changes
Fixes #688