Skip to content

Feature: Improve awareess about current path and current program/project #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2018

Conversation

screamerbg
Copy link
Contributor

This small PR aims to improve the awareness of the user about the current location and current program by adding output to every mbed command.

Here's an example:

D:\Work\smcc-tests\simple-mbed-cloud-client> mbed detect
[mbed] Working path "D:\Work\smcc-tests\simple-mbed-cloud-client" (library)
[mbed] Program path "D:\Work\smcc-tests"
[mbed] No mbed targets were detected on your system.

and also

D:\Work\smcc-tests> mbed detect
[mbed] Working path "D:\Work\smcc-tests" (program)
[mbed] No mbed targets were detected on your system.

@screamerbg screamerbg changed the title Feature: Improve path location and program/project awareness Feature: Improve awareess about current path and current program/project Nov 1, 2018
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

Not sure what that last commit was about, but CI didn not like it one bit.

@screamerbg
Copy link
Contributor Author

@cmonr Working on it ;)

@screamerbg
Copy link
Contributor Author

@cmonr looks like all is good 👍

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

Interesting. Still LGTM.

Kinda odd that GH didn't clear my original OK with the new commits...

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

@theotherjimmy Thoughts?

@theotherjimmy
Copy link
Contributor

@cmonr We can change the settings to dismiss stale reviews if you think it would be appropriate.

@theotherjimmy theotherjimmy merged commit ae35417 into ARMmbed:master Nov 12, 2018
@cmonr
Copy link
Contributor

cmonr commented Nov 12, 2018

@theotherjimmy I think it would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants