Modify "mbed new" to create mbed_app.json with default content. #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridadan
reviewed
Jan 8, 2019
| @@ -221,6 +222,13 @@ def hide_progress(max_width=80): | |||
| if sys.stdout.isatty(): | |||
| sys.stdout.write("\r%s\r" % (' ' * max_width)) | |||
|
|
|||
| def create_default_mbed_app(): | |||
| # Default data content | |||
| data = {'target_overrides':{'K64F':{'platform.stdio-baud-rate': 9600}}} | |||
There was a problem hiding this comment.
How would you feel about swapping the K64F for * so it would be generic for all targets?
Suggested change
| data = {'target_overrides':{'K64F':{'platform.stdio-baud-rate': 9600}}} | |
| data = {'target_overrides':{'*':{'platform.stdio-baud-rate': 9600}}} |
There was a problem hiding this comment.
@bridadan There are targets that have non-9600 default baud rates because they can't support 9600, I think.
There was a problem hiding this comment.
Ah good point (pretty sure some silicon lab targets do that).
|
This PR will need a rebase to bring in the fixes for the Circle CI configuration. |
aashishc1988
force-pushed
the
default_mbed_app
branch
from
1066e0d to
e0fd7b2
Compare
bridadan
approved these changes
Jan 14, 2019
theotherjimmy
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify "mbed new" to create mbed_app.json with default content.
Fixes #648