Skip to content

Fix: Add --force flag to git fetch to allow tags to be fetched in git 2.20 #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

screamerbg
Copy link
Contributor

Add --force flag to git fetch to allow tags to be fetched in git 2.20+ (related to the moving 'latest' branch in Mbed OS).

Also limit the remote repos used during fetch and push to the default one (remove --all flag from git push and git fetch).

See #831 (comment)

…20+ (related to the moving 'latest' branch in Mbed OS)
@screamerbg screamerbg requested a review from cmonr February 1, 2019 12:38
@screamerbg screamerbg changed the title Add --force flag to git fetch to allow tags to be fetched in git 2.20 Fix: Add --force flag to git fetch to allow tags to be fetched in git 2.20 Feb 1, 2019
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just one question regarding the removal of the --all option.

cmonr
cmonr previously approved these changes Feb 1, 2019
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wondering about the removal of --all as well

@bridadan
Copy link
Contributor

bridadan commented Feb 7, 2019

Since fixing this is a priority, I've added the --all flags back for now. They can always be removed in a follow up PR.

@theotherjimmy theotherjimmy merged commit c2878fe into ARMmbed:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants