This repository was archived by the owner on Apr 24, 2019. It is now read-only.
Change uint8_t bitfields to int #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
suggested changes
Dec 12, 2016
| @@ -146,7 +146,7 @@ typedef struct sn_nsdl_static_resource_parameters_ { | |||
| uint16_t resourcelen; /**< 0 if dynamic resource, resource information in static resource */ | |||
| bool external_memory_block:1; /**< 0 means block messages are handled inside this library, | |||
| otherwise block messages are passed to application */ | |||
| uint8_t mode:2; /**< STATIC etc.. */ | |||
| int mode:2; /**< STATIC etc.. */ | |||
There was a problem hiding this comment.
Never use "int" bitfields. It's undefined whether they're signed or unsigned. Always make them explicitly "signed" or "unsigned" (you can then leave out the "int").
GCC and ARMCC do actually have different behaviour on this - been bitten by that before.
|
If I am not remembering it wrong, the sign of a int in bitfield is implementation specific. It would be better to use "unsigned int". |
kuggenhoffen
force-pushed
the
bitfields-to-ints
branch
from
4413d93 to
5bbf61d
Compare
kjbracey
approved these changes
Dec 12, 2016
Closed
TeroJaasko
pushed a commit
that referenced
this pull request
Dec 14, 2016
Use unsigned int for bitfields for C99 compliance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c ISO 1990 bitfields can be only int