Improve how generate_psa_constants handles compatibility aliases #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
enhancement
|
@gilles-peskine-arm Could you please rebase and retarget the development branch if these changes are still relevant and desired? |
|
I'm pretty sure this is still relevant. It got stalled because no one reviewed it. I can pick it up if someone's available to review it. |
|
I can review |
No indented semantic change.
Support continuation lines and remove comments.
gilles-peskine-arm
force-pushed
the
psa-error-compatibility_aliases
branch
from
e0fb66a to
6c3e632
Compare
gilles-peskine-arm
changed the base branch from
psa-api-1.0-beta
to
development
gilles-peskine-arm
added
needs: review
|
Rebased to current |
Rather than hard-coding a list of deprecated aliases, assume that anything that's deprecated is an alias or otherwise not desired.
This was renamed from PSA_ERROR_TAMPERING_DETECTED. Add a backward compatibility alias in case somebody was already using it.
gilles-peskine-arm
force-pushed
the
psa-error-compatibility_aliases
branch
from
6c3e632 to
1983512
Compare
dgreen-arm
approved these changes
Sep 19, 2019
|
CI failures were only API changes with deprecated aliases (that's ok) and random DTLS failures (unrelated to this PR). Ok to merge. |
gilles-peskine-arm
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve how generate_psa_constants handles compatibility aliases. Declare a missing alias
PSA_ERROR_TAMPERING_DETECTED.Targeting the API branch because that's where the renamings have been happening.