-
Notifications
You must be signed in to change notification settings - Fork 96
Fix the license header of hkdf #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please could you let me know how to reproduce this issue? (invoke the script - apache_to_gpl.pl)
The copyright year information, Is that allowed? |
@jainvikas8
Well, AFAIK, in Apache, every time a file is modified, its copyright year should be modified as well. Although I don't consider this change significant enough to merit an update in copyright year, this file has been changed during 2019 in other commits, so I modified the year as well. In fact, I am not sure the starting year should be 2016, as this file was introduced on 2018. |
steps to reproduce:
The license header will not change |
Additional note : This issue is seen on Mbed TLS 2.16.2 Apache. |
Yes, this is a known flaky test issue with Gnu TLS DTLS client |
Change the license header of `hkdf.h` to a format the that script `apache_to_gpl.pl` knows how to parse.
5a22dbb
to
40244bc
Compare
I updated the copyright year to reflect the correct years that this file has been modified. |
Looks fine to me, able to reproduce the issue. @Patater please comment on the licensing year. Thanks. |
@jainvikas8 As answered by legal, the copyright year should reflect every year the file was modified. This means that in this |
Change the license header of
hkdf.h
to a format the that scriptapache_to_gpl.pl
knows how to parse.