Return right error code. #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue : 126 ARMmbed#126 PSA_ERROR_BUFFER_TOO_SMALL error returned when we check for output_size.
gilles-peskine-arm
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Normally I'd ask for a non-regression test, but this is an area that isn't well-tested in the first place, so this can wait. Tracking the lack of testing at #200
gilles-peskine-arm
added
bug
|
CI failed only due to a known issue with the ABI checking script, and there's obviously no ABI change here, so it's as good as a pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #126
When running psa-arch-tests API - 0.9 on the crypto library one of the tests fails which expects a right return code from psa_asymmetric_encrypt when the size of output buffer supplied is inadequate.
These psa-arch-tests are PSA compliance tests which are run against the mbed-crypto library.
Please refer
Further, the test can be run on your local Linux machine with the help of this script.
So returning PSA_ERROR_BUFFER_TOO_SMALL error code passes this test.
This fix is a pre-requisite to make psa-arch-tests run as a CI for any raised PR job.