-
Notifications
You must be signed in to change notification settings - Fork 96
New function psa_copy_key #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f603c71
New function psa_copy_key
gilles-peskine-arm 122d002
Fix memory leak in psa_copy_key
gilles-peskine-arm 57ab721
Test psa_copy_key
gilles-peskine-arm 8c1247f
Add psa_copy_key tests with policy constraints
gilles-peskine-arm 6b156df
Don't consider RIPEMD160 a PSA_ALG_ANY_HASH candidate
gilles-peskine-arm aec5a7f
psa_copy_key: minor documentation clarification
gilles-peskine-arm e84d5d2
psa_copy_key: Add test cases to specifically check non-exportability
gilles-peskine-arm c9516fb
Document exercise_key and fix one incorrect usage
gilles-peskine-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test to ensure that passing a lax constraint parameter will not make the effective key policy more lax than the source/target policy?
Also, API design question: if we can set the policy of the target key before doing a copy, why do we need to additionally support an additional constraint here? Is this new constraint applied to and saves as the new target key policy the copy is complete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding tests, see
copy_key_policy
andcopy_fail
intest_suite_psa_crypto.data
.The reason for the seemingly redundant
constraint
parameter is that it allows the copier to atomically constraint the policy. This is necessary for the use case described above: the owner of a key shares it with a recipient, and can't trust the recipient to have set a policy that the owner of the original key agrees to.