Move psa_destroy_key and psa_copy_key to Key Management section #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on the latest |
|
The commits look a bit weird. Could you squash them into one commit? I don't believe you are trying to make more than one semantic change, so one commit would be the most readable and reviewable. |
|
Squashed |
gilles-peskine-arm
added
the
needs: review
gilles-peskine-arm
previously approved these changes
Sep 6, 2019
Patater
added
the
needs: work
|
Rebased 👍 |
gilles-peskine-arm
approved these changes
Sep 11, 2019
gilles-peskine-arm
removed
the
needs: work
|
CI failure is only files that need updating in Mbed TLS repo concurrently with updating the submodule. |
Patater
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently psa_destroy_key and psa_copy_key are in the import/export section but they ought to be in the key management section. So I've simply moved them.