Adapt ECDSA wrapper to new EC public key format #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please mention what tests did you perform on that code? |
Previously, PSA used SubjectPublicKeyInfo structures to serialize EC public keys. This has recently been changed to using ECPoint structures instead, but the wrapper making PSA ECDSA verification available through Mbed TLS' PK API hasn't yet been adapted accordingly - which is what this commit does. Luckily, Mbed TLS' PK API offers two functions mbedtls_pk_write_pubkey() and mbedtls_pk_write_pubkey_der(), the latter exporting a SubjectPublicKeyInfo structure and the former exporting an ECPoint structure in case of EC public keys. For the adaptation of the ECDSA wrapper ecdsa_verify_wrap() it is therefore sufficient to use mbedtls_pk_write_pubkey() instead of mbedtls_pk_write_pubkey_der().
hanno-becker
force-pushed
the
ec_pubkey_fmt_adapt_ecdsa_verify_wrap
branch
from
5a0810e to
5d5e90a
Compare
|
Sibling Mbed-TLS/mbedtls#2382 passes |
hanno-becker
added
the
needs: review
AndrzejKurek
previously approved these changes
Jan 28, 2019
|
Note: the only travis failures are in a known-fragile DTLS 3d interop test. The same tests passed on Jenkins passed. |
mpg
previously approved these changes
Jan 28, 2019
mpg
removed
the
needs: review
|
@AndrzejKurek @mpg @Patater Fixed, please re-review. |
AndrzejKurek
approved these changes
Jan 29, 2019
mpg
approved these changes
Jan 29, 2019
|
CI only failed in known-intermittent timing test on BSD, so is as good as a pass. |
Patater
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, PSA used
SubjectPublicKeyInfostructures to serialize EC public keys. This has been changed in #13 to usingECPointstructures instead, but the wrapper making PSA ECDSA verification available through Mbed TLS' PK API hasn't yet been adapted accordingly - which is what this PR does.Luckily, Mbed TLS' PK API offers two functions
mbedtls_pk_write_pubkey()andmbedtls_pk_write_pubkey_der(), the latter exporting aSubjectPublicKeyInfostructure and the former exporting anECPointstructure in case of EC public keys. For the adaptation of the ECDSA wrapperecdsa_verify_wrap()it is therefore sufficient to usembedtls_pk_write_pubkey()instead ofmbedtls_pk_write_pubkey_der().This PR is the sibling of Mbed-TLS/mbedtls#2382 to the Mbed TLS repository.