-
Notifications
You must be signed in to change notification settings - Fork 96
Streamline PSA key type and curve encodings #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gilles-peskine-arm
merged 23 commits into
ARMmbed:development
from
gilles-peskine-arm:psa-streamline_encodings-types_and_curves
Jan 31, 2020
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8fe6e0d
Symmetric key types only use the upper 16 bits of psa_key_type_t
gilles-peskine-arm 7bfcfac
Change key type encodings to avoid bit 16
gilles-peskine-arm 2eea95c
Extract the block size from the key type encoding
gilles-peskine-arm c7ef5b3
Rework mbedlts group id to PSA curve conversion
gilles-peskine-arm 4295e8b
Rework PSA curve to mbedlts group id conversion
gilles-peskine-arm 5055b23
Expose mbedtls/psa curve identifier conversions from psa_crypto.c
gilles-peskine-arm fc2459d
Remove mbedtls_psa_translate_ecc_group
gilles-peskine-arm d8197cb
mbedtls_psa_parse_tls_ecc_group: make no assumption on PSA encodings
gilles-peskine-arm 025fccd
Change the encoding of EC curves and DH groups to include the size
gilles-peskine-arm 228abc5
Define EC curve family constants
gilles-peskine-arm 45c29ce
Move size-specific curve/group constants to crypto_compat.h
gilles-peskine-arm 85f47c9
pk tests: USE_PSA_CRYPTO: test attributes of the PSA key
gilles-peskine-arm 33b1c69
pk tests: USE_PSA_CRYPTO: test several curves
gilles-peskine-arm 89177e8
Convert USE_PSA_CRYPTO pk interface to the new PSA EC curve encoding
gilles-peskine-arm 4080c91
pk: USE_PSA_CRYPTO: don't translate via the TLS ID
gilles-peskine-arm 80d26fb
Switch psa_crypto tests to the new curve encoding
gilles-peskine-arm d1959dc
Change auxiliary functions for TLS to the new PSA EC curve encoding
gilles-peskine-arm b87b719
Remove old values of curve encodings
gilles-peskine-arm f65ed6f
Change key types to a 16-bit encoding
gilles-peskine-arm 46e6f9d
Document the vendor range for EC curve and DH group families
gilles-peskine-arm 7d7c8dc
Test parsing invalid key type in storage
gilles-peskine-arm 7cfcb3f
Change the encoding of key types to have a parity bit
gilles-peskine-arm 3e819b7
psa_key_agreement_ecdh: zeroize output on failure
gilles-peskine-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: typo in commit 27f8944 -
Remove the values of curve encodings that is based
- encodings/values are plural, so I'd assume that it should bethat **are** based
.Also,
andinclude
->and include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the commit message.