Fix some pylint warnings #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
previously approved these changes
Dec 19, 2019
tests/scripts/check-test-cases.py
Outdated
| @@ -26,6 +26,8 @@ | |||
| import sys | |||
|
|
|||
| class Results: | |||
| """Stores file and line information about errors | |||
There was a problem hiding this comment.
Nitpick: PEP 257 says to write ”Store …“, not “Stores …”, and to end with a period. PEP 257 also says a one-line docstring “should really fit on one line”, and a multi-line docstring should start with a one-line summary.
There was a problem hiding this comment.
I've updated this.
dgreen-arm
force-pushed
the
fix-pylint-warnings
branch
from
3f46746 to
e121bb8
Compare
gilles-peskine-arm
previously approved these changes
Dec 20, 2019
This was referenced Dec 20, 2019
dgreen-arm
force-pushed
the
fix-pylint-warnings
branch
from
e121bb8 to
74d59c8
Compare
Patater
suggested changes
Dec 20, 2019
tests/scripts/check-test-cases.py
Outdated
| @@ -41,6 +42,7 @@ def warning(self, file_name, line_number, fmt, *args): | |||
| self.warnings += 1 | |||
|
|
|||
| def collect_test_directories(): | |||
| """Gets the relative path for the TLS and Crypto test directories.""" | |||
tests/scripts/check-test-cases.py
Outdated
| @@ -55,6 +57,7 @@ def collect_test_directories(): | |||
| return directories | |||
|
|
|||
| def check_description(results, seen, file_name, line_number, description): | |||
| """Checks test case descriptions for errors.""" | |||
Add docstrings where they were missing and fix a too-long line
dgreen-arm
force-pushed
the
fix-pylint-warnings
branch
from
74d59c8 to
1822061
Compare
Patater
approved these changes
Dec 20, 2019
|
Mbed OS tests expected to be failing until ARMmbed/mbed-os#12150 is merged |
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbed-crypto
that referenced
this pull request
Feb 3, 2020
Previously in d875285: * ARMmbed#333: Streamline PSA key type encodings: prepare * ARMmbed#323: Initialise return values to an error Previously in dbcb442: * ARMmbed#291: Test MBEDTLS_CTR_DRBG_USE_128_BIT_KEY * ARMmbed#334: Fix some pylint warnings Previously in ceceedb: * ARMmbed#348: Bump version to Mbed TLS 2.20.0 and crypto SO version to 4 * ARMmbed#354: Fix incrementing pointer instead of value In this commit: * ARMmbed#349: Fix minor defects found by Coverity * ARMmbed#179: Add option to build SHA-512 without SHA-384 * ARMmbed#327: Implement psa_hash_compute and psa_hash_compare * ARMmbed#330: Streamline PSA key type and curve encodings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few warnings that the check_python_files component of all.sh was complaining about