ctr_drbg: Clarify reseed_counter values before seeding #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patater
added
enhancement
AndrzejKurek
previously approved these changes
Jan 9, 2020
gilles-peskine-arm
previously approved these changes
Jan 9, 2020
include/mbedtls/ctr_drbg.h
Outdated
| * to use as a nonce for the initial seeding. | ||
| * to use as a nonce for the initial seeding, | ||
| * or -1 if no nonce length has been explicitly | ||
| * set. (See mbedtls_ctr_drbg_set_nonce_len()) |
There was a problem hiding this comment.
Suggested change
| * set. (See mbedtls_ctr_drbg_set_nonce_len()) | |
| * set (see mbedtls_ctr_drbg_set_nonce_len()). |
yanesca
previously approved these changes
Jan 9, 2020
Patater
dismissed stale reviews from yanesca, gilles-peskine-arm, and AndrzejKurek
via
a5c655b
Patater
force-pushed
the
reseed-counter-value-comment
branch
from
c6cc168 to
a5c655b
Compare
AndrzejKurek
previously approved these changes
Jan 9, 2020
Before the initial seeding, reseed_counter used to always be 0. Now, the value depends on whether or not the user has explicitly set the amount of data to get from the nonce (via e.g. mbedtls_ctr_drbg_set_nonce_len()). Add comments to clarify the possible values reseed_counter can have before the initial seeding.
Patater
force-pushed
the
reseed-counter-value-comment
branch
from
a5c655b to
a15c713
Compare
yanesca
approved these changes
Jan 9, 2020
Patater
added
needs: ci
|
CI is failing ASan for some reason. I can't reproduce the failures locally. This PR changes only a comment, so OK to merge (as comments can't cause ASan to fail). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the initial seeding, reseed_counter used to always be 0. Now, the
value depends on whether or not the user has explicitly set the amount
of data to get from the nonce (via e.g.
mbedtls_ctr_drbg_set_nonce_len()). Add comments to clarify the possible
values reseed_counter can have before the initial seeding.