psa: Check generator validity before read #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patater
added
bug
gilles-peskine-arm
previously approved these changes
Feb 15, 2019
dgreen-arm
reviewed
Feb 18, 2019
library/psa_crypto.c
Outdated
| @@ -3911,7 +3922,13 @@ psa_status_t psa_generator_read( psa_crypto_generator_t *generator, | |||
| exit: | |||
| if( status != PSA_SUCCESS ) | |||
| { | |||
| /* Preserve the algorithm upon errors, but clear all sensitive state. | |||
| * This allows us to differentiate between exhaused generators and | |||
There was a problem hiding this comment.
Typo: exhaused -> exhausted
|
Rebasing to address review comments and to resolve merge conflicts. |
Check generator validity (i.e. that alg has been initialized) before allowing reads from the generator or allowing reads of the generator's capacity. This aligns our implementation with the documented error code behavior in our crypto.h and the PSA Crypto API.
Patater
force-pushed
the
check-generator-validity
branch
from
ee116e5 to
cf2010c
Compare
dgreen-arm
approved these changes
Feb 18, 2019
|
Rebased. Unfortunately, the base change had to happen in order to get the merge conflicts resolved, and we've merged the latest Mbed TLS code in (so the base is quite different). Probably easiest to diff between diffs on this one instead of using GitHub's "force-pushed" diff. Old branch up at https://github.com/Patater/mbed-crypto/tree/check-generator-validity-1 |
gilles-peskine-arm
approved these changes
Feb 18, 2019
|
CI failure is the FreeBSD timing test, a known flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check generator validity (i.e. that alg has been initialized) before
allowing reads from the generator or allowing reads of the generator's
capacity.
This aligns our implementation with the documented error code behavior
in our crypto.h and the PSA Crypto API.
Fixes https://github.com/ARMmbed/mbedtls-psa/issues/183