psa: Add backwards compatible error codes #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is having issues with psa_constant_names right now, due to duplicate cases getting generated. |
gilles-peskine-arm
requested changes
Feb 21, 2019
yanesca
previously approved these changes
Feb 21, 2019
Patater
force-pushed
the
deprecated-psa-errors
branch
from
7eaa219 to
3cac665
Compare
Add deprecated error codes to help transition between the previous version of the PSA Crypto specification and the current one.
Patater
force-pushed
the
deprecated-psa-errors
branch
from
3cac665 to
5e6d24c
Compare
Patater
added
the
needs: review
|
OK to review. CI is failing a TLS-using-PSA for chachapoly test. Unsure why TLS is trying to use PSA for chachapoly right now, since that's not supported in Mbed Crypto yet. Unsure why we didn't see this previously. |
|
Discussed with @hanno-arm. He's seen this before and "Session resume using cache, DTLS: timeout > delay" is a known flaky test. The error is not due to use of chachapoly, but due to the alert and client hello messages getting coalesced. The server expects the alert and handles it, but never sees the subsequent client hello because it is only waiting for that hello without a timeout of 0. |
gilles-peskine-arm
approved these changes
Feb 21, 2019
yanesca
approved these changes
Feb 21, 2019
Patater
removed
needs: ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deprecated error codes to help transition between the previous
version of the PSA Crypto specification and the current one.