modify check-names.sh and list-macros.sh to work with PSA constants #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed processing of PSA macros in check names script. This required changes in: *list-macros.sh to scan the PSA headers *check-names to scan PSA files and allow PSA_* macro names
alekshex
reviewed
Jan 8, 2019
tests/scripts/check-names.sh
Outdated
| NL=' | ||
| ' | ||
| sed -n 's/MBED..._[A-Z0-9_]*/\'"$NL"'&\'"$NL"/gp \ | ||
| $HEADERS library/*.c \ | ||
| | grep MBEDTLS | sort -u > _MBEDTLS_XXX | ||
|
|
gilles-peskine-arm
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
This PR makes mbedtls and psa headers interchangeable for the sake of defining macros. This was already the case for functions.
We'll probably revisit this at some point to enforce some separation between the two APIs but it's ok for now to not make a distinction.
Patater
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed processing of PSA macros in check names script.
This required changes in:
list-macros.sh to scan the PSA headers
check-names to scan PSA files and allow PSA_* macro names