Use generated source files from Mbed TLS #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't depend on the C compiler's default output file name and path. Make knows what it wants to build and where it should go, and this may not always align with the C compiler default, so tell the C compilter to output to the Make target explicitly.
Patater
added
bug
library/Makefile
Outdated
|
|
||
| # For files generated by the parent project (Mbed TLS) when building Mbed | ||
| # Crypto as a submodule, ensure that the parent project instance is used. | ||
| ifdef USE_CRYPTO_SUBMODULE |
There was a problem hiding this comment.
I'd recommend changing that to an ifneq ($(USE_CRYPTO_SUBMODULE), 0), same as here:
Mbed-TLS/mbedtls@fc5a7f5
since USE_CRYPTO_SUBMODULE=0 will also have it defined.
AndrzejKurek
suggested changes
Apr 26, 2019
Patater
force-pushed
the
tls-generated-sources
branch
from
f345d4a to
c8cba4f
Compare
|
Rebased to use more robust option checking. |
When building as a submodule of a parent project, like Mbed TLS, use the parent projects generated source files (error.c, version.c, version_features.c)
When building as a submodule of a parent project, like Mbed TLS, use the parent projects generated source files (error.c, version.c, version_features.c)
Patater
force-pushed
the
tls-generated-sources
branch
from
c8cba4f to
18d4789
Compare
|
Rebased to use |
AndrzejKurek
approved these changes
Apr 29, 2019
Patater
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of generated source files that both Mbed Crypto and Mbed TLS can create. When created from Mbed Crypto, they contain only symbols, errors, options and other things visible within Mbed Crypto itself. When Mbed TLS generates these source files, it uses symbols, errors, options and other things visible from both Mbed TLS and Mbed Crypto. When building libmbedcrypto.a or libmbedcrypto.so as a submodule from Mbed TLS, use the Mbed-TLS-generated files as these are the most comprehensive and useful to the rest of Mbed TLS.