This repository was archived by the owner on Aug 19, 2021. It is now read-only.
Add member-function overloads for event functions #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following overloads:
- event(T *, R (T::*)(A...), A...)
- event(const T *, R (T::*)(A...) const, A...)
- event(volatile T *, R (T::*)(A...) volatile, A...)
- event(const volatile T *, R (T::*)(A...) const volatile, A...)
To the following functions:
- EventQueue::call
- EventQueue::call_in
- EventQueue::call_every
- EventQueue::event
- Event::Event
This does allow the traditional form of mbed callbacks:
Event<void(int)> event(&object, &Object::method, arg1);
event->post(arg2);
But also adds a significant number of overloads due to the cv
attributes. It may be worth it in this situation to conform to the
user's expectations.
geky
force-pushed
the
event-member-functions
branch
from
bb0faeb to
2595a65
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following overloads:
To the following functions:
This does allow the traditional form of mbed callbacks:
But also adds a significant number of overloads due to the cv attributes. It may be worth it in this situation to conform to the user's expectations.
@pan-, @bogdanm thoughts?