This repository was archived by the owner on Aug 19, 2021. It is now read-only.
Removed problematic event overloads for function-objects #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unforunately, it is very difficult to infer the parameters of a function-object generically in C++03 without any additional type information. The current implementation fails to due so, and the compiler simply bails with "unable to deduce template parameter". Rather than leaving the user with a small novel of error messages, this patch removes the problematic event overloads, leaving only event overloads for simple pointer types. As a side effect, the limited sfinae in mbed-events is no longer needed.
geky
force-pushed
the
remove-function-object-overloads
branch
from
b95a0ca to
f414b78
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, it is very difficult to infer the parameters of a function-object generically in C++03 without any additional type information. The current implementation fails to do so, and the compiler simply bails with "unable to deduce template parameter".
Rather than leaving the user with a small novel of error messages, this patch removes the problematic event overloads, leaving only event overloads for simple pointer types. As a side effect, the limited sfinae in mbed-events is no longer needed.