This repository was archived by the owner on Aug 19, 2021. It is now read-only.
Add EVENTS_EVENT_SIZE define for calculated queue allocations #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the events library, the structure of an event is correctly not part of the public api. Unfortunately, this makes it difficult to calculate the space needed for a finite set of events. EVENTS_EVENT_SIZE is defined as the space needed for the smallest event, the event allocated in event_call. This allows queues to be created based on a number of events: equeue_create(&q, 12 * (EVENTS_EVENT_SIZE+sizeof(struct context)));
Add EVENTS_EVENT_SIZE define for calculated queue allocations
Adjusted to account for size of Callback, which is a bit larger than an average C callback due to type information and member function pointers.
geky
added a commit
that referenced
this pull request
Aug 8, 2016
Add set of event queue composition functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mbed-events library, the structure of an event is correctly hidden from the public api. Unfortunately, this makes it difficult to calculate the space needed for a finite-set of events.
In this pr, EVENTS_EVENT_SIZE is defined as the space needed for a single Callback<void()> event.
This allows queues to be created with the exact size required for Callback<void()> or any callback with a single word of associated context:
For events with different sized contexts, the exact size can still be calculated, although it is quite a bit uglier. This should be less common than Callback<void()>, and was shown in previous versions to be difficult to reason about when compared to raw buffer sizes: