Skip to content

Add support for LPC54114 & LPC54608 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2017
Merged

Add support for LPC54114 & LPC54608 #175

merged 2 commits into from
May 16, 2017

Conversation

mmahadevan108
Copy link
Contributor

Signed-off-by: Mahadevan Mahesh [email protected]

@mmahadevan108
Copy link
Contributor Author

@maclobdell @0xc0170

@bridadan
Copy link
Contributor

It looks like the LPC54114_M0 definition is missing in the mbed database and the entry for the LPC54114_M4 doesn't seem to quite match that which is listed here. @maclobdell can you take a look?

Signed-off-by: Mahadevan Mahesh <[email protected]>
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
Copy link
Contributor Author

@bridadan @maclobdell I have changed LPC54114_M4 to LPC54114. I have also included support for LPC54608 in this PR.

@mmahadevan108 mmahadevan108 changed the title Add support for LPC54114 Add support for LPC54114 & LPC54608 May 15, 2017
@maclobdell
Copy link
Contributor

@mmahadevan108 Does the interface firmware enumerate two separate mass storage device drivers - one for each core? We allocated 1054 for this platform. 1055 is available and we can allocate it too, but I want to confirm if to unique IDs are needed. Thanks.

@bridadan
Copy link
Contributor

@maclobdell not sure what our convention is regarding how entries in the database match with the mbed-ls listing. The names in mbedls don't match any entries in the database at the moment, is this a requirement?

@maclobdell
Copy link
Contributor

@bridadan it should match. Looks like ARMmbed/mbed-os#4290 has been updated so it matches. This platform has two targets, one for each core.

@mmahadevan108
Copy link
Contributor Author

It enumerates as 1. Initially I thought I would make it as 2 separate devices.

@maclobdell
Copy link
Contributor

the updates match the system. I approve.

Thanks.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge adbridge merged commit 7569cd7 into ARMmbed:master May 16, 2017
@mmahadevan108 mmahadevan108 deleted the Add_LPC54114_Support branch May 16, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants