Update platform database when it's out of date #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... |
theotherjimmy
force-pushed
the
update-platform-db
branch
from
3e1cb41 to
3e9882f
Compare
bridadan
approved these changes
Oct 23, 2017
mbed_lstools/platform_database.py
Outdated
| except (IOError, ValueError) as exc: | ||
| if db is LOCAL_PLATFORM_DATABASE: | ||
| logger.warning( | ||
| "Error loading database %s: %s; Recereating", db, str(exc)) |
There was a problem hiding this comment.
Lil typo here: Recereating ->Recreating
There was a problem hiding this comment.
The branch name also contains a typo, FYI.
theotherjimmy
force-pushed
the
update-platform-db
branch
from
4392d04 to
d7c627f
Compare
|
@bridadan Typo in code fixed. |
bridadan
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And test it
review @bridadan?