Correct traceback caused by None "target_id" #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridadan
approved these changes
Dec 8, 2017
| self.assertEqual(to_check[0]['target_id'], "0241BEEFDEAD") | ||
| self.assertEqual(to_check[0]['platform_name'], 'foo_target') | ||
| self.assertEqual(to_check[1]['target_id'], None) | ||
| self.assertEqual(to_check[1]['platform_name'], None) |
|
Can we proceed to get this merged? We'd like to make sure it's fixed before the 5.7 release. Thanks! |
|
@theotherjimmy @bridadan are you planning a new release with this change this/next week? Just wanted to make sure this is being shipped in time for the 5.7 release. Thanks! |
|
@theotherjimmy is out of office this week (working just not in the office) but I'll try to get a hold of him since I can't make releases. |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #276