Skip to content

Remove log calls to root logger #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2018
Merged

Remove log calls to root logger #286

merged 1 commit into from
Jan 3, 2018

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Jan 3, 2018

Fixes #285.

There were a few stray calls to the root logger. This caused complications when used with other modules that make use of the logging library. They are removed in this patch.

cc @theotherjimmy @jonikula

@coveralls
Copy link

coveralls commented Jan 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 74.419% when pulling 574e1ec on bridadan:remove_root_logging into e5bac65 on ARMmbed:master.

@theotherjimmy theotherjimmy merged commit 13663cd into ARMmbed:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bridadan @coveralls @theotherjimmy