-
Notifications
You must be signed in to change notification settings - Fork 178
Update note in mbed_targets.md #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update note to include method to force ArmC5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnotherButler - I'm not sure we have to split that into 2 pages. This makes it harder to find. Now we have 2 ways of doing same thing explained in 2 pages. And also we eventually have to remove this and individual modifications to these section in separate pages makes it harder. I would prefer this to go in the same place as other doc and but its ok to make it shorter as you recommended without losing the main message that we will be deprecating ARMC5 in future.
@SenRamakri This does the same thing, but it's for different users. In particular |
@theotherjimmy - Although in general that is the case, I don't think anyone porting new targets should use AC5. Also compiler documentation will be applicable to both porting and app development not just app development. |
The this should not be documented. |
This is documentation about |
I think there is some confusion, it was never meant to be a "porting" related doc, its only meant to document how to use AC5. But yes, it does refer targets.json which is one way of doing it. |
@SenRamakri @AnotherButler We could instead place this in the toolchain section, so long as this advice is clearly marked as "For porting a target that cannot use ArmC6 at this time". That way Application developer are not presented with an option that encourages modification of Mbed OS, as they're not doing target porting. (from offline discussion) |
Part of the confusion is that when |
@AnotherButler - I'll make the changes to the PR as @theotherjimmy suggested and push to other PR. Thanks for the quick review @theotherjimmy and @AnotherButler. |
@AnotherButler - Please close this PR as I have modifications to the other PR as we discussed. |
Update note to include method to force ArmC5.