Skip to content

Update note in mbed_targets.md #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AnotherButler
Copy link
Contributor

Update note to include method to force ArmC5.

Update note to include method to force ArmC5.
Copy link
Contributor

@SenRamakri SenRamakri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnotherButler - I'm not sure we have to split that into 2 pages. This makes it harder to find. Now we have 2 ways of doing same thing explained in 2 pages. And also we eventually have to remove this and individual modifications to these section in separate pages makes it harder. I would prefer this to go in the same place as other doc and but its ok to make it shorter as you recommended without losing the main message that we will be deprecating ARMC5 in future.

@theotherjimmy
Copy link
Contributor

@SenRamakri This does the same thing, but it's for different users. In particular mbed_app.json modification is for an application developer. This is for someone porting a target. I would not expect them to look in the same location for this information.

@SenRamakri
Copy link
Contributor

@theotherjimmy - Although in general that is the case, I don't think anyone porting new targets should use AC5. Also compiler documentation will be applicable to both porting and app development not just app development.

@theotherjimmy
Copy link
Contributor

I don't think anyone porting new targets should use AC5.

The this should not be documented.

@theotherjimmy
Copy link
Contributor

Also compiler documentation will be applicable to both porting and app development not just app development.

This is documentation about targets.json which only applies to porting. Application developers should not be encouraged to modify Mbed OS.

@SenRamakri
Copy link
Contributor

I think there is some confusion, it was never meant to be a "porting" related doc, its only meant to document how to use AC5. But yes, it does refer targets.json which is one way of doing it.

@theotherjimmy
Copy link
Contributor

@SenRamakri @AnotherButler We could instead place this in the toolchain section, so long as this advice is clearly marked as "For porting a target that cannot use ArmC6 at this time". That way Application developer are not presented with an option that encourages modification of Mbed OS, as they're not doing target porting. (from offline discussion)

@theotherjimmy
Copy link
Contributor

Part of the confusion is that when targets.json gets involved, it's immediately about target porting.

@SenRamakri
Copy link
Contributor

@AnotherButler - I'll make the changes to the PR as @theotherjimmy suggested and push to other PR. Thanks for the quick review @theotherjimmy and @AnotherButler.

@SenRamakri
Copy link
Contributor

@AnotherButler - Please close this PR as I have modifications to the other PR as we discussed.

@AnotherButler AnotherButler deleted the AnotherButler-patch-3 branch March 15, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants