OOB_5.12 Clarification regarding label directories #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
suggested changes
Mar 20, 2019
There was a problem hiding this comment.
This is incorrect. target.extra_labels_add is not a different configuration variable, and target.extra_labels_remove is also available.
Please document that you may use both add and remove to modify the target.extra_labels value in addition to directly setting it.
|
Thanks for your review and clarification, @theotherjimmy ! |
theotherjimmy
suggested changes
Mar 20, 2019
|
Thanks again! |
theotherjimmy
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to a documentation enhancement requested by @alzix as part of #1018.