Add Basic baremetal application example #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit file, mostly for precise language and example formatting.
AnotherButler
approved these changes
Mar 20, 2019
iriark01
reviewed
Mar 21, 2019
docs/baremetal_example.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| ## Bare metal example | |||
|
|
|||
| To start using the bare metal profile on Mbed OS 5, please see the blinky bare metal example: | |||
There was a problem hiding this comment.
Isn't it normally Blinky?
There was a problem hiding this comment.
We have a new example that's basically blinky for bare metal; it's different from the standard blinky.
There was a problem hiding this comment.
Oh, do you just mean capitalization?
SenRamakri
reviewed
Mar 21, 2019
docs/baremetal_example.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| ## Bare metal example | |||
|
|
|||
| To start using the bare metal profile on Mbed OS 5, please see the blinky bare metal example: | |||
There was a problem hiding this comment.
How about changing this sentence to - "To learn about using the bare metal profile on Mbed OS 5,... ".
Everything else looks great.
Fix phrasing as suggested in comments, and capitalize "Blinky" for consistency as suggested in comments.
SenRamakri
approved these changes
Mar 21, 2019
|
ping @bulislaw |
bulislaw
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example page for a starting bare-metal application the baremetal book.
@bulislaw