Skip to content

Add FPGA info to spi.md #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add FPGA info to spi.md #1087

merged 1 commit into from
Jun 19, 2019

Conversation

AnotherButler
Copy link
Contributor

Add content about running SPI tests on the FPGA.

Add content about running SPI tests on the FPGA.
@AnotherButler AnotherButler requested a review from mprse June 13, 2019 16:43
@AnotherButler
Copy link
Contributor Author

ping @mprse

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added information is correct, but in this document defined/undefined behavior sections and are stale...

Some modifications have been added while working on example driver implementations and tests:
https://github.com/ARMmbed/mbed-os/blob/feature-hal-spec-spi/docs/design-documents/hal/0000-spi-overhaul.md#defined-behaviours

@mprse
Copy link
Contributor

mprse commented Jun 19, 2019

@jamesbeyond ping

@AnotherButler
Copy link
Contributor Author

Because the added documentation is correct, I'll merge this PR. Let's make any changes to existing text in another PR. As we make changes to the code, please put PRs up against this repo. This is the official published documentation repo. Duplicating content in other repositories leads to out-of-sync, out-of-date content.

@AnotherButler AnotherButler merged commit 7689ed1 into development Jun 19, 2019
@AnotherButler AnotherButler deleted the AnotherButler-patch-4 branch June 19, 2019 18:33
AnotherButler pushed a commit that referenced this pull request Jun 19, 2019
Apply changes from PR #1087 to v5.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants