Skip to content

Remove Arm Compiler 5 from style.md #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Conversation

AnotherButler
Copy link
Contributor

Remove Arm Compiler 5 requirement.

Remove Arm Compiler 5 requirement.
@AnotherButler
Copy link
Contributor Author

@kjbracey-arm @bulislaw Should this requirement be removed now?

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to replace it with 6. Also @kjbracey-arm can you update the C/C++ standards below to match your recent changes?

@kjbracey
Copy link
Contributor

Yes, next bit should be

- Uses the GNU11 standard for C.
- Uses the GNU++14 standard for C++.

But that's assuming we are outright dropping the "must compile for ARM Compiler 5" . If that remains, ARM C 5 selects GNU99/GNU++11, and its "GNU++11" is only a subset (about 70% of language additions, no library).

I'm currently still uncertain whether I'm okay to push something to master that will not work in ARM C 5's C++11 subset. Changing these docs would give me permission, so that's a higher-level-than-me decision. Personally, I'm in favour.

Add requirements suggested in comments.
@AnotherButler
Copy link
Contributor Author

@bulislaw Is this OK to merge, or should we talk about this in person?

@AnotherButler AnotherButler merged commit 3c8f31e into development Jun 17, 2019
@AnotherButler AnotherButler deleted the AnotherButler-patch-6 branch June 17, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants