Clarify maximum timeout in Watchdog.md #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify line about maximum timeout to resolve issue #1133
|
ping @jamesbeyond @0xc0170 |
0xc0170
requested changes
Aug 23, 2019
docs/porting/target/Watchdog.md
Outdated
| @@ -10,7 +10,7 @@ Implement the ResetReason API when implementing the Watchdog API. The ResetReaso | |||
|
|
|||
| - Sleep and debug modes don't stop the watchdog timer from counting down. | |||
| - The function `hal_watchdog_init` is safe to call repeatedly. The function's implementation must not do anything if `hal_watchdog_init` has already initialized the hardware watchdog timer. | |||
| - Maximum supported timeout is `UINT32_MAX` milliseconds; minimum timeout is 1ms. | |||
| - `UINT32_MAX` milliseconds is the maxinum allowed max_timeout `hal_watchdog_get_platform_features()` returns; minimum timeout is 1 ms. | |||
Fix typo caught in engineering review.
AnotherButler
pushed a commit
that referenced
this pull request
Aug 23, 2019
Apply changes from PR #1134 to v5.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify line about maximum timeout to resolve issue #1133