Deprecate Wait.md #1170
Merged
Deprecate Wait.md #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace content with deprecation warning.
bulislaw
requested changes
Nov 21, 2019
|
So should we keep the body content and add a note that says "Warning: The |
|
ping @bulislaw |
bulislaw
reviewed
Nov 25, 2019
There was a problem hiding this comment.
I think we should basically say the same as the deprecation notice (maybe with links): MBED_DEPRECATED_SINCE("mbed-os-5.14", "'wait' is deprecated in favor of explicit sleep functions. To sleep, 'wait' should be replaced by " "'ThisThread::sleep_for' (C++) or 'thread_sleep_for' (C). If you wish to wait (without sleeping), call " "'wait_us'. 'wait_us' is safe to call from ISR context.")
I'll update the examples not to use deprecated calls.
Update warning to match code.
|
@bulislaw Does this resolve your concerns? |
bulislaw
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace content with deprecation warning.