Skip to content

Add docs for Callback config #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2020
Merged

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Dec 9, 2019

Documentation for changes in ARMmbed/mbed-os#12036

@40Grit
Copy link

40Grit commented Dec 9, 2019

@AGlass0fMilk

@AnotherButler
Copy link
Contributor

@iriark01 This is waiting on engineering review before editing.

@kjbracey
Copy link
Contributor Author

kjbracey commented Apr 6, 2020

Part of the change was moved to ARMmbed/mbed-os#12761. These docs are largely fine if that doesn't make it, but the wording does strongly suggest that the default for the callback-nontrivial is false. It's true until 12761 lands.

@iriark01
Copy link
Contributor

@kjbracey-arm was the intention to hold on this PR until 12761 makes it in?

@kjbracey
Copy link
Contributor Author

I'm fine with it going now, but maybe it could be edited. That first paragraph talking about how the "setting can almost always be left set to false" implies that it is false by default, but it isn't yet.

Maybe just take out the word "left"? Then it works either way, I think.

Make more ambiguous about default, as there's currently a pending change.

Co-Authored-By: Irit Arkin <[email protected]>
@iriark01
Copy link
Contributor

@kjbracey-arm looks like I can merge this?

@kjbracey
Copy link
Contributor Author

Yes, thanks!

@iriark01 iriark01 merged commit b2eb55b into ARMmbed:development May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants