workflow: remove rollup #1232
Merged
workflow: remove rollup #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not used anymore, label will be removed as well.
0xc0170
commented
Feb 11, 2020
|
|
||
| - Rollup pull requests drastically lower the time to test many pull requests at once. Instead of putting many pull requests through CI, only one goes through testing. This lowers the load on the CI infrastructure and helps close pull requests sooner. | ||
|
|
||
| - The second, more subtle problem that rollup pull requests solve is the case in which two pull requests pass testing on their own, but as soon as they join together, the way they interact with each other causes tests to fail. See more [about semantic conflicts](https://bors.tech/essay/2017/02/02/pitch). |
There was a problem hiding this comment.
this could be the only use case we can have in the future. However for this simple use case, we can keep the label and describe it as its on 260, not the entire section
|
😢 |
cmonr
approved these changes
Feb 11, 2020
|
@cmonr We shall not need this anymore :) |
AnotherButler
approved these changes
Feb 12, 2020
|
Does this apply to 5.15, too? |
It's process thing so yes, it would. Any PR on Github |
AnotherButler
pushed a commit
that referenced
this pull request
Feb 24, 2020
Apply changes from PR #1232 to v5.15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used anymore, label will be removed as well.
cc @ARMmbed/mbed-os-maintainers