Add license PR checks + how to run it locally #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
commented
Feb 18, 2020
| @@ -103,6 +103,22 @@ If you decide to use a different license for your work, follow the same pattern: | |||
|
|
|||
| - If more than one license applies to the source file, use an SPDX license expression (see [SPDX Specification, Appendix IV](https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60)), to reflect the presence of multiple licenses in your *LICENSE.md* file and in each source file. | |||
|
|
|||
| ## License check in pull requests | |||
|
|
|||
| We use scancode-toolkit to enforce the license in binaries and libraries. Please see "Continuous integration (CI) testing" section for more information. | |||
There was a problem hiding this comment.
I can move Please see "Continuous integration (CI) testing" section for more information. to the end of this section, shall I?
There was a problem hiding this comment.
I'm agnostic on this one.
|
The pull request adding license check using scancode was merged to master. This can progress (as the checks are being active from today for all PRs). |
adbridge
requested changes
Feb 24, 2020
docs/contributing/guidelines/ci.md
Outdated
| @@ -24,7 +24,7 @@ Travis configuration is located in the [.travis.yml](https://github.com/ARMmbed/ | |||
| - Features/netsocket. | |||
| - **travis-ci/events** - Checks that Mbed OS compiles and run events tests. | |||
| - **travis-ci/gitattributestest** - Checks there are no changes after clone. This checks that `.gitattributes` is used correctly. | |||
| - **travis-ci/licence_check** - Checks there is no GPL license text in the code. | |||
| - **travis-ci/licence_check** - Checks there is only permissive license in files, including SPDX identifier. | |||
There was a problem hiding this comment.
only a permissive license in the files,
| @@ -103,6 +103,22 @@ If you decide to use a different license for your work, follow the same pattern: | |||
|
|
|||
| - If more than one license applies to the source file, use an SPDX license expression (see [SPDX Specification, Appendix IV](https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60)), to reflect the presence of multiple licenses in your *LICENSE.md* file and in each source file. | |||
|
|
|||
| ## License check in pull requests | |||
|
|
|||
| We use scancode-toolkit to enforce the license in binaries and libraries. Please see "Continuous integration (CI) testing" section for more information. | |||
There was a problem hiding this comment.
I'm agnostic on this one.
|
|
||
| We use scancode-toolkit to enforce the license in binaries and libraries. Please see "Continuous integration (CI) testing" section for more information. | ||
|
|
||
| To scan the files in SCANCODE folder, please use: |
|
Updated, fixed the above requested changes |
adbridge
requested changes
Feb 24, 2020
docs/contributing/guidelines/ci.md
Outdated
| @@ -24,7 +24,7 @@ Travis configuration is located in the [.travis.yml](https://github.com/ARMmbed/ | |||
| - Features/netsocket. | |||
| - **travis-ci/events** - Checks that Mbed OS compiles and run events tests. | |||
| - **travis-ci/gitattributestest** - Checks there are no changes after clone. This checks that `.gitattributes` is used correctly. | |||
| - **travis-ci/licence_check** - Checks there is no GPL license text in the code. | |||
| - **travis-ci/licence_check** - Checks only a permissive license in the files, including SPDX identifier. | |||
There was a problem hiding this comment.
I think i missed a bit:
Checks that there is only a permissive license in the files,
|
Fixed as well |
0xc0170
force-pushed
the
fix_license_check
branch
from
da2e050 to
6e6478a
Compare
adbridge
approved these changes
Feb 24, 2020
AnotherButler
approved these changes
Feb 24, 2020
AnotherButler
pushed a commit
that referenced
this pull request
Feb 25, 2020
Apply changes from PR #1235 to v5.15.
AnotherButler
pushed a commit
that referenced
this pull request
Feb 25, 2020
Apply changes from PR #1235 to v5.15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on ARMmbed/mbed-os#12437
Once it is merged, this can go in (no release dependency, will be running on master for every PR)
I added a section to our license guide - how to run the license check
@ARMmbed/mbed-os-maintainers Please review