Skip to content

Updated the flow control tutorial #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2020
Merged

Updated the flow control tutorial #1287

merged 6 commits into from
Apr 9, 2020

Conversation

evedon
Copy link
Contributor

@evedon evedon commented Mar 31, 2020

Some updates:

  • Corrected several inaccuracies in tutorial.
  • Busy wait is only mentionned at the beginning ; it is emphasized that if possible alternatives should be used.
  • Introduced ThisThread::sleep_for and thread_sleep_for APIs.
  • Renamed Busy wait button section to Active polling button.

@AnotherButler
Copy link
Contributor

I think this will pass Travis again if we rebase.

evedon and others added 2 commits April 3, 2020 10:57
@evedon evedon force-pushed the ed-flow-control branch from 92012d0 to 591426a Compare April 3, 2020 09:59
@AnotherButler AnotherButler requested a review from iriark01 April 3, 2020 19:52
@AnotherButler
Copy link
Contributor

@iriark01 This is waiting on engineering review. It will then be ready for review.

iriark01
iriark01 suggested changes Apr 9, 2020
View reviewed changes
@iriark01
Copy link
Contributor

iriark01 commented Apr 9, 2020

Should this go out to 6.0-alpha as well?

@evedon
Copy link
Contributor Author

evedon commented Apr 9, 2020

Should this go out to 6.0-alpha as well?

yes

@iriark01
Removing iBeacon
d378523 
I want to make sure this can build before I merge it
@iriark01
Copy link
Contributor

iriark01 commented Apr 9, 2020

Merging; will cherry pick into alpha

@iriark01 iriark01 merged commit 3548fa3 into development Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iriark01 iriark01 iriark01 requested changes

@bulislaw bulislaw bulislaw approved these changes

@AnotherButler AnotherButler Awaiting requested review from AnotherButler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evedon @AnotherButler @iriark01 @bulislaw