Skip to content

Add hal/flash porting guide #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add hal/flash porting guide #129

wants to merge 4 commits into from

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 22, 2017

There is a new folder hal where a porting guides will be placed.
The first one, flash.md file is part of this commit. It contains information
about flash HAL API porting plus changes required for bootloader to use this API.

This is for 5.4 (flash API is part of it). This porting guide should describe flash HAL API, how to port it (2 options, both of them should be described).

Please review, I expect some changes within a day.

cc @c1728p9 @sg- @ashok-rao @AnotherButler

Rendered

There is a new folder hal where a porting guides will be placed.
The first one, flash.md file is part of this commit. It contains information
about flash HAL API porting plus changes required for bootloader to use this API.
1. Update target to support bootloader
* Update linker script
* Implement flash HAL API
* Add pack support to mbed-os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed to remove this point until things are finalized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Russ is working currently on adding this to the mbed-os. I can remove it for now, and add it later.

@AnotherButler If you do any edits, please remove this, will be added with more information later


There are two options how to implement flash HAL:

1. CMSIS flash algorithm routines - quick to implement (use CMSIS device packs and scripts to generate binary blobs). As these algos do not have well specified behavior, they might do things like disabling cache, reconfigure clocks or any other actions you might not expect. Therefore a proper testing is required. First, make sure your device is supported by CMSIS device packs. Run a script in the mbedmicro/FlashAlgo to generate flash blob that should be checked in into targets HAL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might help to provide the link to the script (flash_algo.py or generate_blobs.py ?? ).
On a side note, @sg- , did we decide to NOT use the FlashAlgo repo completely at all? Does this whole section needs to be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation should be updated to point to the script here:
ARMmbed/mbed-os#3996

The FlashAlgo repo only needs to be used if the algorithm provided by the pack needs to be modified.


```

Be careful with these defines, they move the application flash sections, thus any sections within flash sectors should be moved accordingly. For instance data section should start >= MBED_APP_SIZE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should start >= MBED_APP_SIZE be start >= MBED_APP_START?

-Add subjects and pronouns.
-Change passive to active voice.
-Standardize style.
-Make minor grammar changes.
@AnotherButler
Copy link
Contributor

@0xc0170 Please review my suggested changes and make sure that I didn't change the meaning of any of your sentences.

Amanda Butler added 2 commits March 22, 2017 20:00
Fix spelling, replace sentence about mbedmicro/FlashAlgo and standardize abbreviations.
Add information about VTOR addresses and change regular text to code
AnotherButler pushed a commit that referenced this pull request Mar 23, 2017
@AnotherButler AnotherButler mentioned this pull request Mar 23, 2017
@AnotherButler
Copy link
Contributor

I am closing this in favor of PR #130 because after careful consideration, I think that is a better location for this document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants