Update PSA porting guide #1416

LDong-Arm · 2021-02-15T18:29:29Z

This PR

removes outdated secure/non-secure target naming convention - Mbed OS only provides the non-secure side, thus there's no point having different names for secure/non-secure sides of a target
removes details steps to use mbed-os-tf-m-regression-tests, as more up-to-date instructions are in the mbed-os-tf-m-regression-tests repo itself
removes the section "Enabling PSA at application level" which does not always work
documents more configurations:
- TF-M version supported
- support for TF-M bootloader and two image slots
- post binary hooks
combines documentation for dual-core targets for Armv8-m targets
replaces the Musca A1 example with Musca S1

jainvikas8 · 2021-02-15T19:10:37Z

docs/porting/security/psa_targets_in_mbed-os.md

@@ -466,7 +396,7 @@ To build TF-M and create an Mbed OS pull request:
    python3 build_tfm.py -m <new target> -t <toolchain> --commit
    ```

-    The command builds TF-M with the config `ConfigCoreIPC.cmake`, copies the TF-M binary to the location defined by the target attribute `tfm_delivery_dir`, and commits the changes to Mbed OS.
+    The command builds TF-M with the config `ConfigCoreIPC`, copies the TF-M binary to the location defined by the target attribute `tfm_delivery_dir`, and commits the changes to Mbed OS.


I think its CoreIPC

jeromecoutant · 2021-02-16T10:03:10Z

docs/porting/security/psa_targets_in_mbed-os.md

- `TargetName`: PSA non-secure target (NSPE).
- `TargetName_NPSA_S`: Non-PSA secure target.
- `TargetName_NPSA`: Non-PSA non-secure target.
-


So what is the new convention ?

For ex, current NUCLEO_L552ZE_Q is used as a legacy coretex M target without trust zone.
When we will support TFM, how this new target should be called ?

For ex, current NUCLEO_L552ZE_Q is used as a legacy coretex M target without trust zone.
When we will support TFM, how this new target should be called ?

I think it should still be called NUCLEO_L552ZE_Q if we support only one flavour. Unless the intention is to provide users both TF-M and non-TF-M options?

First intention was to provide both options.
But maybe we need to change our mind.

@LMESTM

First intention was to provide both options.

This should be okay, we can still have two target names (for TF-M and non-TF-M flavours) in this case I think. I removed the naming guideline section from the doc, only because no targets currently follow them.

I'd recommend removing the naming guideline for now as it is not currently used. As @LDong-Arm says, both options could still be used and so this could be re-visited when a use case arises.

jeromecoutant · 2021-02-16T10:07:15Z

docs/porting/security/psa_targets_in_mbed-os.md

@@ -466,7 +396,7 @@ To build TF-M and create an Mbed OS pull request:
    python3 build_tfm.py -m <new target> -t <toolchain> --commit


This is a linux only command ?

Maybe mbed cli2 could be used ? mbedtools tfm -m xxx ?

It runs on Windows and macOS too, as long as python and dependencies are installed. Mbed CLI 2 support for PSA/TF-M targets and repositories will be added, at which point we'll update the documentation.

docs/porting/security/psa_targets_in_mbed-os.md

evedon · 2021-02-18T18:33:11Z

docs/porting/security/psa_targets_in_mbed-os.md

- `TargetName`: PSA non-secure target (NSPE).
- `TargetName_NPSA_S`: Non-PSA secure target.
- `TargetName_NPSA`: Non-PSA non-secure target.
-


I'd recommend removing the naming guideline for now as it is not currently used. As @LDong-Arm says, both options could still be used and so this could be re-visited when a use case arises.

For PSA/TF-M targets, Mbed OS provides the non-secure side only, because secure-side binaries are built directly using TF-M's repository and checked into the Mbed OS tree. Having one target name for each board is sufficient, so we remove this outdated section.

To avoid duplicaton, we just need to point users to the mbed-os-tf-m-regression-tests repository which contains up-to-date instructions on how to use our scripts to build and run TF-M, regression tests and PSA compliance tests.

Overriding `inherits` in `mbed_app.json` is not always feasible - if a target already has another inheritance in `targets.json`, the existing one will be overriden. To avoid potential issues, we should not recommend this method of enabling PSA.

Add documentation for more TF-M-related configurations: * TF-M version supported * Support for TF-M bootloader and two image slots * post binary hooks Combine documentation for dual-core and Armv8-M targets, as the steps are basically identical. This reduces maintenance required and improves readability.

From TF-M v1.2, ARM_MUSCA_A1 has been deprecated from Mbed OS.

Single-core v7-M targets use Mbed PSA service instead of TF-M.

evedon · 2021-03-04T12:33:03Z

@donatieng Could you merge this PR please?

LDong-Arm requested review from evedon and jainvikas8 February 15, 2021 18:29

LDong-Arm changed the title ~~Update PSA porting guide~~ DO NOT MERGE: Update PSA porting guide Feb 15, 2021

LDong-Arm force-pushed the tf-m-v1.2-update branch from 9893d5e to d3e6b6e Compare February 15, 2021 18:47

jainvikas8 reviewed Feb 15, 2021

View reviewed changes

LDong-Arm force-pushed the tf-m-v1.2-update branch from d3e6b6e to 1f5e62d Compare February 16, 2021 09:58

jeromecoutant reviewed Feb 16, 2021

View reviewed changes

LDong-Arm force-pushed the tf-m-v1.2-update branch from 1f5e62d to d21fcad Compare February 16, 2021 12:54

LDong-Arm marked this pull request as draft February 16, 2021 12:55

LDong-Arm marked this pull request as ready for review February 16, 2021 13:04

LDong-Arm force-pushed the tf-m-v1.2-update branch 3 times, most recently from be70eb1 to b4c3a65 Compare February 17, 2021 16:11

LDong-Arm marked this pull request as draft February 17, 2021 17:11

evedon reviewed Feb 18, 2021

View reviewed changes

LDong-Arm added 3 commits February 19, 2021 10:28

Remove details of mbed-os-tf-m-regression-tests

01e5f1b

To avoid duplicaton, we just need to point users to the mbed-os-tf-m-regression-tests repository which contains up-to-date instructions on how to use our scripts to build and run TF-M, regression tests and PSA compliance tests.

LDong-Arm force-pushed the tf-m-v1.2-update branch from b4c3a65 to 498e285 Compare February 19, 2021 10:28

LDong-Arm added 3 commits February 19, 2021 10:30

Replace ARM_MUSCA_A1 example with ARM_MUSCA_S1

ac4a863

From TF-M v1.2, ARM_MUSCA_A1 has been deprecated from Mbed OS.

Remove the claim that TF-M is a must for PSA

4bf6847

Single-core v7-M targets use Mbed PSA service instead of TF-M.

LDong-Arm force-pushed the tf-m-v1.2-update branch from 498e285 to 4bf6847 Compare February 19, 2021 10:30

LDong-Arm requested review from evedon and jainvikas8 February 19, 2021 10:31

evedon approved these changes Feb 19, 2021

View reviewed changes

LDong-Arm mentioned this pull request Feb 25, 2021

Update TF-M support to v1.2 ARMmbed/mbed-os#14354

Merged

LDong-Arm changed the title ~~DO NOT MERGE: Update PSA porting guide~~ Update PSA porting guide Mar 3, 2021

LDong-Arm marked this pull request as ready for review March 3, 2021 14:50

donatieng merged commit 08bf7fa into ARMmbed:development Mar 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update PSA porting guide #1416

Update PSA porting guide #1416

Uh oh!

LDong-Arm commented Feb 15, 2021 •

edited

Loading

Uh oh!

jainvikas8 Feb 15, 2021

Uh oh!

LDong-Arm Feb 16, 2021

Uh oh!

LDong-Arm Feb 19, 2021

Uh oh!

jeromecoutant Feb 16, 2021

Uh oh!

LDong-Arm Feb 16, 2021

Uh oh!

jeromecoutant Feb 16, 2021

Uh oh!

LDong-Arm Feb 16, 2021 •

edited

Loading

Uh oh!

evedon Feb 18, 2021

Uh oh!

jeromecoutant Feb 16, 2021

Uh oh!

LDong-Arm Feb 16, 2021

Uh oh!

Uh oh!

evedon Feb 18, 2021

Uh oh!

evedon commented Mar 4, 2021

Uh oh!

Uh oh!

		@@ -466,7 +396,7 @@ To build TF-M and create an Mbed OS pull request:
		python3 build_tfm.py -m <new target> -t <toolchain> --commit

Update PSA porting guide #1416

Update PSA porting guide #1416

Uh oh!

Conversation

LDong-Arm commented Feb 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LDong-Arm Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evedon commented Mar 4, 2021

Uh oh!

Uh oh!

LDong-Arm commented Feb 15, 2021 •

edited

Loading

LDong-Arm Feb 16, 2021 •

edited

Loading