Skip to content

Add documentation for the ConditionVariable class #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2017

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Oct 28, 2017

Add a description and example for the ConditionVariable class.

Add a description and example for the ConditionVariable class.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 28, 2017

This should go into 5.7 as it is a new feature. Once ARMmbed/mbed-os#3648 is merged and dthe doxygen is available I'll update this to include the class reference.

Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Just move the example into teams/mbed_example and add the path to doxygen (should be known by deciphering the others).

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 28, 2017

Will do. I held off on creating an example because this change isn't in mbed-os yet. @sg- can the example use master of mbed-os or does it need to be fixed to a release? If it needs to be on a release I won't be able to add an importable example until 5.7.

Make minor copy edits.
@sg-
Copy link
Contributor

sg- commented Oct 30, 2017

It should be from a release so staging all this until 5.7 shouldn't be a problem.

Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to move the example when it goes live

Add API reference.
@AnotherButler AnotherButler merged commit 833ae8c into ARMmbed:new_engine Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants