Skip to content

BLE: Add reference of Battery service. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2017

Conversation

pan-
Copy link
Member

@pan- pan- commented Nov 16, 2017

This page describes what the Bluetooth Battery Service is and what the BatteryService class do.

@pan-
Copy link
Member Author

pan- commented Nov 16, 2017

@sg- @AnotherButler Could you review ?

Make minor copy edits for clarity.
@AnotherButler AnotherButler requested a review from sg- November 21, 2017 20:15
@AnotherButler
Copy link
Contributor

@pan- Is this for 5.7, or is it applicable now?

@pan-
Copy link
Member Author

pan- commented Nov 28, 2017

It is applicable now.

Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the use of SIG versus body


The <a href="https://www.bluetooth.org/docman/handlers/downloaddoc.ashx?doc_id=245138" target="_blank">Bluetooth Battery Service</a> defines how to expose a battery charge level through a BLE link. It allows a client - usually a smartphone application - of a device to read the current battery charge level and follow its evolution.

The BatteryService class implements the Bluetooth Battery Service as defined by the Bluetooth body. Makers of BLE devices operating on battery can use the API to expose interoperably the charge level of their products.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bluetooth body or SIG (special interest group) as they refer to themselves as?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced Bluetooth body by Bluetooth SIG.

@AnotherButler AnotherButler requested a review from sg- December 7, 2017 17:17
Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the merge conflict

@AnotherButler
Copy link
Contributor

@pan- I'm having some trouble finding the correct API reference link. Is the doxygen for this in a features folder?

@pan-
Copy link
Member Author

pan- commented Dec 10, 2017

Yes, bless as a whole is in a feature folder.

@AnotherButler AnotherButler merged commit c9c449d into ARMmbed:new_engine Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants