RTC and time API pages updated #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make minor copy edits.
Fix capitalization and link.
Update content for active voice.
There was a problem hiding this comment.
@deepikabhavnani Please review my changes, and make sure I didn't accidentally change the meaning.
|
@AnotherButler - Changes look fine, I have corrected one doxy link |
AnotherButler
approved these changes
Nov 29, 2017
sg-
suggested changes
Dec 4, 2017
docs/reference/api/platform/Time.md
Outdated
| ### Time hello, world | ||
| You can convert time to a human-readable format using `ctime`, `localtime`, `strftime` and other C standard functions. | ||
|
|
||
| You cannot use `mktime` and `localtime` C standard library functions in an interrupt handler with the GCC toolchain. We have added dedicated routines for `mktime` and `localtime`, which are optimized and faster then C standard library functions, to overcome this issue. |
There was a problem hiding this comment.
I dont understand this sentence. Did we add new functions with the same name?
There was a problem hiding this comment.
No we added same functions as _rtc_mktime, _rtc_localtime. Will update the doc with new name
sg-
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated RTC and Time API document.
@AnotherButler - Changes are valid for mbed-os 5.6 as well, shall I create one more PR for that?
@sg- Please review